fix(i18n): clarify browser pairing tab label #733

Merged
admin merged 1 commits from fix/pairing-code-tab-label into dev 2026-10-25 06:43:42 +00:00
Owner

Update the browser-auth tab label from “one-time code” to “pairing code”, making its purpose clearer while keeping the OTP field accessible label descriptive. Apply the wording consistently across all seven supported locales.

Validation: JSON parsing for all locale files; git diff --check.

Update the browser-auth tab label from “one-time code” to “pairing code”, making its purpose clearer while keeping the OTP field accessible label descriptive. Apply the wording consistently across all seven supported locales. Validation: JSON parsing for all locale files; `git diff --check`.
rvnminers-A-and-N left a comment
Owner

This matches the other side now: Settings → Access already says "Create pairing code" and "Pairing code copied", so both ends use the same name.

One string on the same screen still says one-time code. browserAuthDescription, the line above the tabs, reads "Pair this browser with a one-time code from a browser already connected to the node." It's the same in all seven locales. With the tab renamed, it might read better as "…with a pairing code from a browser already connected…".

The screen-reader label, "Eight-digit one-time code", is fine as it is. It describes the field, and the input also keeps autocomplete="one-time-code".

This matches the other side now: Settings → Access already says "Create pairing code" and "Pairing code copied", so both ends use the same name. One string on the same screen still says one-time code. `browserAuthDescription`, the line above the tabs, reads "Pair this browser with a **one-time code** from a browser already connected to the node." It's the same in all seven locales. With the tab renamed, it might read better as "…with a pairing code from a browser already connected…". The screen-reader label, "Eight-digit one-time code", is fine as it is. It describes the field, and the input also keeps `autocomplete="one-time-code"`.
Author
Owner

This undoes #727, which merged about an hour ago with Austin's agreement. #727 made the tab "One-time code" and changed browserPairCodeLabel to "Eight-digit one-time code" so that the tab and the field it opens say the same thing (see Austin's review on #727). With this change, the tab says "Pairing code" again but the field still says "one-time code", which is the mismatch Austin asked to avoid. Could we close this, or if "pairing code" is the better wording, change the field label in every locale too and check with Austin first? Otherwise the wording will keep switching back and forth.

This undoes #727, which merged about an hour ago with Austin's agreement. #727 made the tab "One-time code" and changed `browserPairCodeLabel` to "Eight-digit one-time code" so that the tab and the field it opens say the same thing (see Austin's review on #727). With this change, the tab says "Pairing code" again but the field still says "one-time code", which is the mismatch Austin asked to avoid. Could we close this, or if "pairing code" is the better wording, change the field label in every locale too and check with Austin first? Otherwise the wording will keep switching back and forth.
Sign in to join this conversation.
No Reviewers
No labels area:client bug i18n
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Sisyphus/Sisyphus#733