fix(i18n): clarify browser pairing tab label #733
No Reviewers
Dismiss Review
Are you sure you want to dismiss this review?
Labels
Clear labels
accessibility
all-platforms
area:agents
area:ai
area:chain
area:ci
area:client
area:daemon
area:p2p
area:project
area:protocol
area:runtime
area:storage
bug
chore
community
dependencies
discussion
discussion/Announcements
discussion/General
discussion/Ideas
discussion/Q&A
discussion/Show and tell
discussion/answered
documentation
duplicate
enhancement
good first issue
help wanted
i18n
infra
invalid
needs:decision
needs:hardware
paired
question
research
security
status:in-review
test
testing
tracking
wontfix
Barrier affecting people with disabilities
Run every platform's packaging and checks on this pull request, not only the three main ones
MCP server, skill, and thinking on the pool
Planner and model providers
Blockchain, SISY, verification
Continuous integration and build workflows
Desktop and web clients
sisyphusd coordinator, worker, scheduler
libp2p hosts, relays, discovery, connections between nodes
Project planning, roadmap, and governance
Protobuf schemas and RPC contracts
Workload execution and environments
Content-addressed storage, IPFS, Kubo, Cluster, S3, names, pinning
Something isn't working
Repository health, templates, Discussions, contributor experience
Updates to actions, Go modules or npm packages
Migrated from GitHub Discussions
GitHub Discussions category: Announcements
GitHub Discussions category: General
GitHub Discussions category: Ideas
GitHub Discussions category: Q&A
GitHub Discussions category: Show and tell
Q&A discussion with an accepted answer
Improvements or additions to documentation
This issue or pull request already exists
New feature or request
Good for newcomers
Extra attention is needed
Translations and right-to-left layouts
Build, CI, releases
This doesn't seem right
Waits on a decision from both owners
Waits on a machine we do not have yet
Built together by both maintainers, with co-authored commits
Further information is requested
Needs investigation or a design decision
Sealing, keys, access control, tokens, the security model
Built and in an open pull request; closes when it merges
Tests, test harnesses and the rehearsal
Roadmap and meta issues
This will not be worked on
type
Feature
A request, idea, or new functionality (GitHub issue type)
type
Task
A specific piece of work (GitHub issue type)
Milestone
No items
No Milestone
V0: prove the loop
Projects
Clear projects
No projects
Sisyphus roadmap
Done
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Sisyphus/Sisyphus#733
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Update the browser-auth tab label from “one-time code” to “pairing code”, making its purpose clearer while keeping the OTP field accessible label descriptive. Apply the wording consistently across all seven supported locales.
Validation: JSON parsing for all locale files;
git diff --check.This matches the other side now: Settings → Access already says "Create pairing code" and "Pairing code copied", so both ends use the same name.
One string on the same screen still says one-time code.
browserAuthDescription, the line above the tabs, reads "Pair this browser with a one-time code from a browser already connected to the node." It's the same in all seven locales. With the tab renamed, it might read better as "…with a pairing code from a browser already connected…".The screen-reader label, "Eight-digit one-time code", is fine as it is. It describes the field, and the input also keeps
autocomplete="one-time-code".This undoes #727, which merged about an hour ago with Austin's agreement. #727 made the tab "One-time code" and changed
browserPairCodeLabelto "Eight-digit one-time code" so that the tab and the field it opens say the same thing (see Austin's review on #727). With this change, the tab says "Pairing code" again but the field still says "one-time code", which is the mismatch Austin asked to avoid. Could we close this, or if "pairing code" is the better wording, change the field label in every locale too and check with Austin first? Otherwise the wording will keep switching back and forth.