test(desktop): cover Access picker at short viewport #547

Merged
admin merged 1 commits from test/access-interface-picker-short-viewport into dev 2026-10-20 02:49:36 +00:00
Owner

Summary

  • Exercise the Access network-interface picker in Electron at the minimum 650px window height.
  • Assert the popup stays inside the viewport in both LTR and Hebrew/RTL while preserving the list and search directions.

Tracks the remaining picker audit in #99; this does not close the broader issue.

Verification

  • Focused Access Electron test
  • npm run test:e2e (42/42)
  • npm run typecheck
  • make cover (every statement covered)
  • actionlint, gofmt -l apps packages skills, `git diff --check
## Summary - Exercise the Access network-interface picker in Electron at the minimum 650px window height. - Assert the popup stays inside the viewport in both LTR and Hebrew/RTL while preserving the list and search directions. Tracks the remaining picker audit in #99; this does not close the broader issue. ## Verification - Focused Access Electron test - `npm run test:e2e` (42/42) - `npm run typecheck` - `make cover` (every statement covered) - `actionlint`, `gofmt -l apps packages skills`, `git diff --check
rvnminers-A-and-N left a comment
Owner

Looks right to me. Shrinking the window before opening the menu means both the LTR and Hebrew bounds checks now run at the 650 px minimum, and the <= 700 assert keeps the RTL half from quietly passing in a tall window.

Looks right to me. Shrinking the window before opening the menu means both the LTR and Hebrew bounds checks now run at the 650 px minimum, and the `<= 700` assert keeps the RTL half from quietly passing in a tall window.
Sign in to join this conversation.
No Reviewers
No labels area:client test
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Sisyphus/Sisyphus#547