test(desktop): cover RTL interface picker #534

Merged
admin merged 1 commits from test/advanced-popovers-audit into dev 2026-10-19 23:22:09 +00:00
Owner

What changed

  • Exercise the Access network-interface picker in Hebrew/RTL in the real Electron app.
  • Assert that the selector and search follow RTL while the interface/IP list stays LTR, the popover stays in the viewport, filtering works, and Done/Escape dismiss it.
  • Document the added end-to-end coverage.

Verification

  • Targeted Access Electron E2E
  • Full Electron E2E: 42/42
  • Desktop unit tests: 110/110
  • Typecheck and production build
  • make cover (100% hand-written Go statement coverage)
  • gofmt, actionlint, git diff --check

Refs #99

## What changed - Exercise the Access network-interface picker in Hebrew/RTL in the real Electron app. - Assert that the selector and search follow RTL while the interface/IP list stays LTR, the popover stays in the viewport, filtering works, and Done/Escape dismiss it. - Document the added end-to-end coverage. ## Verification - Targeted Access Electron E2E - Full Electron E2E: 42/42 - Desktop unit tests: 110/110 - Typecheck and production build - make cover (100% hand-written Go statement coverage) - gofmt, actionlint, git diff --check Refs #99
rvnminers-A-and-N left a comment
Owner

Read it through. The RTL test checks what matters: the control and search follow Hebrew, the interface list stays LTR so names and IPs read right, the popover stays in the viewport, and both Done and Escape close it. Leaving the locale set is fine since the profile is thrown away in finally. Approving; merge once the last checks are green.

Read it through. The RTL test checks what matters: the control and search follow Hebrew, the interface list stays LTR so names and IPs read right, the popover stays in the viewport, and both Done and Escape close it. Leaving the locale set is fine since the profile is thrown away in `finally`. Approving; merge once the last checks are green.
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Sisyphus/Sisyphus#534