Sisyphus/Sisyphus
4
0
Fork 0
Code Issues 74 Pull Requests 11 Actions 3 Packages Projects Releases Activity

chore: regenerate the blob service's gRPC code #516

Merged
admin merged 1 commits from chore/regen-blob-proto into dev 2026-10-19 16:23:27 +00:00
Conversation 1 Commits 1 Files Changed 1
+16 -8
rvnminers-A-and-N commented 2026-10-19 15:40:00 +00:00
Owner
Copy Link
Copy Source

The comments on BlobService.Replication in proto/sisyphus/v1/blob.proto were updated without regenerating the Go code, so the doc comment in blob_grpc.pb.go still describes the old behaviour. I noticed it while regenerating for #515.

This is protoc output for blob.proto only, and comments are the only change: 16 lines in blob_grpc.pb.go, nothing in blob.pb.go, and the generated header is unchanged. The build passes.

The comments on `BlobService.Replication` in `proto/sisyphus/v1/blob.proto` were updated without regenerating the Go code, so the doc comment in `blob_grpc.pb.go` still describes the old behaviour. I noticed it while regenerating for #515. This is `protoc` output for `blob.proto` only, and comments are the only change: 16 lines in `blob_grpc.pb.go`, nothing in `blob.pb.go`, and the generated header is unchanged. The build passes.
excho0 approved these changes 2026-10-19 15:42:22 +00:00
excho0 left a comment
Owner
Copy Link
Copy Source

Compared the generated BlobService comments in blob_grpc.pb.go with the source comments on Replication in proto/sisyphus/v1/blob.proto. The generated client and server comments match the source, and the change is limited to generated documentation with no wire/API changes. The current diff is correct. /cc @rvnminers-A-and-N

Compared the generated `BlobService` comments in `blob_grpc.pb.go` with the source comments on `Replication` in `proto/sisyphus/v1/blob.proto`. The generated client and server comments match the source, and the change is limited to generated documentation with no wire/API changes. The current diff is correct. /cc @rvnminers-A-and-N
Sign in to join this conversation.
Reviewers
No Reviewers
excho0
Labels
Clear labels
accessibility
Barrier affecting people with disabilities
 all-platforms
Run every platform's packaging and checks on this pull request, not only the three main ones
 area:agents
MCP server, skill, and thinking on the pool
 area:ai
Planner and model providers
 area:chain
Blockchain, SISY, verification
 area:ci
Continuous integration and build workflows
 area:client
Desktop and web clients
 area:daemon
sisyphusd coordinator, worker, scheduler
 area:p2p
libp2p hosts, relays, discovery, connections between nodes
 area:project
Project planning, roadmap, and governance
 area:protocol
Protobuf schemas and RPC contracts
 area:runtime
Workload execution and environments
 area:storage
Content-addressed storage, IPFS, Kubo, Cluster, S3, names, pinning
 bug
Something isn't working
 chore
community
Repository health, templates, Discussions, contributor experience
 dependencies
Updates to actions, Go modules or npm packages
 discussion
Migrated from GitHub Discussions
 discussion/Announcements
GitHub Discussions category: Announcements
 discussion/General
GitHub Discussions category: General
 discussion/Ideas
GitHub Discussions category: Ideas
 discussion/Q&A
GitHub Discussions category: Q&A
 discussion/Show and tell
GitHub Discussions category: Show and tell
 discussion/answered
Q&A discussion with an accepted answer
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 i18n
Translations and right-to-left layouts
 infra
Build, CI, releases
 invalid
This doesn't seem right
 needs:decision
Waits on a decision from both owners
 needs:hardware
Waits on a machine we do not have yet
 paired
Built together by both maintainers, with co-authored commits
 question
Further information is requested
 research
Needs investigation or a design decision
 security
Sealing, keys, access control, tokens, the security model
 status:in-review
Built and in an open pull request; closes when it merges
 test
testing
Tests, test harnesses and the rehearsal
 tracking
Roadmap and meta issues
 wontfix
This will not be worked on
type
Feature
A request, idea, or new functionality (GitHub issue type)
type
Task
A specific piece of work (GitHub issue type)
No labels area:protocol chore
Milestone
No items
No Milestone First release
Projects
Clear projects
No projects
Sisyphus roadmap
Done
Assignees
Clear assignees
excho0 (Excho) rvnminers-A-and-N (Austin L.) sisyphus-bot (Sisyphus CI bot)
No Assignees rvnminers-A-and-N
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Sisyphus/Sisyphus#516