@excho0 the desktop check failed on 96a5fdf, and it doesn't look like a flake. The new settings layout no longer matches what the e2e tests expect (job log):
app.e2e.mjs:619, :659 and :742: openSettingsCategory(page, 'Interface language' | 'Theme' | 'Local node') times out after 20s. Those categories seem to have been folded into the consolidated General section.
:835: the provider card's Edit button, found through [data-slot="card"].rounded-2xl, is no longer there under that selector.
:907: "Settings is narrower than the full padded content width". The page's left or right edge moved off the content edges, which may be on purpose with the new layout or may be a real regression.
The PR's validation list covers npm test, but not npm run test:e2e, which is where these live. Happy to update the e2e to the new structure on your branch if you'd like, or I'll stay out of it if you're already on it.
@excho0 the `desktop` check failed on 96a5fdf, and it doesn't look like a flake. The new settings layout no longer matches what the e2e tests expect ([job log](https://github.com/sisyphus-network/Sisyphus/actions/runs/38897301400/job/116961133069)):
- `app.e2e.mjs:619`, `:659` and `:742`: `openSettingsCategory(page, 'Interface language' | 'Theme' | 'Local node')` times out after 20s. Those categories seem to have been folded into the consolidated General section.
- `:835`: the provider card's `Edit` button, found through `[data-slot="card"].rounded-2xl`, is no longer there under that selector.
- `:907`: "Settings is narrower than the full padded content width". The page's left or right edge moved off the content edges, which may be on purpose with the new layout or may be a real regression.
The PR's validation list covers `npm test`, but not `npm run test:e2e`, which is where these live. Happy to update the e2e to the new structure on your branch if you'd like, or I'll stay out of it if you're already on it.
@rvnminers-A-and-N Thanks for catching these. I updated the E2E selectors and assertions on my branch for the consolidated settings sections and shared desktop scroll area; I am rerunning the affected flows now, including the width/scroll restoration case.
@rvnminers-A-and-N Thanks for catching these. I updated the E2E selectors and assertions on my branch for the consolidated settings sections and shared desktop scroll area; I am rerunning the affected flows now, including the width/scroll restoration case.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
rvnminers-A-and-N
Summary
Validation
npm run typechecknpm test(84 passing)npm run build@excho0 the
desktopcheck failed on96a5fdf, and it doesn't look like a flake. The new settings layout no longer matches what the e2e tests expect (job log):app.e2e.mjs:619,:659and:742:openSettingsCategory(page, 'Interface language' | 'Theme' | 'Local node')times out after 20s. Those categories seem to have been folded into the consolidated General section.:835: the provider card'sEditbutton, found through[data-slot="card"].rounded-2xl, is no longer there under that selector.:907: "Settings is narrower than the full padded content width". The page's left or right edge moved off the content edges, which may be on purpose with the new layout or may be a real regression.The PR's validation list covers
npm test, but notnpm run test:e2e, which is where these live. Happy to update the e2e to the new structure on your branch if you'd like, or I'll stay out of it if you're already on it.@rvnminers-A-and-N Thanks for catching these. I updated the E2E selectors and assertions on my branch for the consolidated settings sections and shared desktop scroll area; I am rerunning the affected flows now, including the width/scroll restoration case.