fix: restore settings scroll after content loads #257

Merged
admin merged 3 commits from fix/settings-scroll-restore into dev 2026-10-14 22:05:32 +00:00
Owner

Summary

  • Keep a saved Settings scroll offset pending until the page has enough content to restore it.
  • Retry restoration when async content/layout changes, without overwriting the saved offset with a temporarily clamped value.
  • Stop observing once restored; normal scrolling then persists as before.

Related to #99. This fixes the failing Settings scroll restoration E2E; it does not close the broader mobile/tablet acceptance issue.

Checks

  • Renderer typecheck passed.
  • Unit tests: 83 passed.
  • Diff whitespace check passed.
  • Hosted Electron E2E pending; no local Electron window was opened.
## Summary - Keep a saved Settings scroll offset pending until the page has enough content to restore it. - Retry restoration when async content/layout changes, without overwriting the saved offset with a temporarily clamped value. - Stop observing once restored; normal scrolling then persists as before. Related to #99. This fixes the failing Settings scroll restoration E2E; it does not close the broader mobile/tablet acceptance issue. ## Checks - Renderer typecheck passed. - Unit tests: 83 passed. - Diff whitespace check passed. - Hosted Electron E2E pending; no local Electron window was opened.
Sign in to join this conversation.
No Reviewers
No labels area:client bug
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Sisyphus/Sisyphus#257