mcpserver: add a save_model_profile admin tool #728
No Reviewers
Dismiss Review
Are you sure you want to dismiss this review?
Labels
Clear labels
accessibility
all-platforms
area:agents
area:ai
area:chain
area:ci
area:client
area:daemon
area:p2p
area:project
area:protocol
area:runtime
area:storage
bug
chore
community
dependencies
discussion
discussion/Announcements
discussion/General
discussion/Ideas
discussion/Q&A
discussion/Show and tell
discussion/answered
documentation
duplicate
enhancement
good first issue
help wanted
i18n
infra
invalid
needs:decision
needs:hardware
paired
question
research
security
status:in-review
test
testing
tracking
wontfix
Barrier affecting people with disabilities
Run every platform's packaging and checks on this pull request, not only the three main ones
MCP server, skill, and thinking on the pool
Planner and model providers
Blockchain, SISY, verification
Continuous integration and build workflows
Desktop and web clients
sisyphusd coordinator, worker, scheduler
libp2p hosts, relays, discovery, connections between nodes
Project planning, roadmap, and governance
Protobuf schemas and RPC contracts
Workload execution and environments
Content-addressed storage, IPFS, Kubo, Cluster, S3, names, pinning
Something isn't working
Repository health, templates, Discussions, contributor experience
Updates to actions, Go modules or npm packages
Migrated from GitHub Discussions
GitHub Discussions category: Announcements
GitHub Discussions category: General
GitHub Discussions category: Ideas
GitHub Discussions category: Q&A
GitHub Discussions category: Show and tell
Q&A discussion with an accepted answer
Improvements or additions to documentation
This issue or pull request already exists
New feature or request
Good for newcomers
Extra attention is needed
Translations and right-to-left layouts
Build, CI, releases
This doesn't seem right
Waits on a decision from both owners
Waits on a machine we do not have yet
Built together by both maintainers, with co-authored commits
Further information is requested
Needs investigation or a design decision
Sealing, keys, access control, tokens, the security model
Built and in an open pull request; closes when it merges
Tests, test harnesses and the rehearsal
Roadmap and meta issues
This will not be worked on
type
Feature
A request, idea, or new functionality (GitHub issue type)
type
Task
A specific piece of work (GitHub issue type)
Milestone
No items
No Milestone
Agents and thinking on the pool
Projects
Clear projects
No projects
Sisyphus roadmap
Done
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Sisyphus/Sisyphus#728
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Part of #650: the model-profile tool that #721 left out until #722 landed.
save_model_profile(offered with--admin)It works the same way as the #721 setters:
ListModelProfilesand changes only the fields given (name,provider,url,model,active). An agent can change a profile's model, or switch the planner to it, without resetting anything else.keep_api_key, asset_modeldoes. The saved key stays while the provider and address stay the same, andhas_api_keyin the reply shows whether one is set.base_urlthatlist_model_profilesreturns, with credentials masked since #722, can be given back unchanged. The node then keeps the stored address.The reply is the node's own
ModelProfile, in the same form as the read tools.Tests
TestAModelProfileIsSavedWithOnlyWhatIsGivencovers:active: falseThe fake node refuses any save that doesn't ask to keep the key. The tool count with
--adminis now 62, andsettings.gois at 100% coverage.Docs
The tool counts are updated in
docs/development.mdandapps/sisyphusd/README.md(62 tools, 14 admin). The admin lists in the README and inskills/sisyphus/SKILL.mdinclude the new tool.I read this against
SaveModelProfileinapi/local.goand found nothing to change:KeepApiKey: truecopies the saved key only whensameServiceholds for the same ID. An admin agent that points an existing profile at anotherurlor provider getshas_api_key: falseback, so it can't send the saved key somewhere new.urlout, the maskedbase_urlfromListModelProfilesgoes back unchanged, andmodelAddressresolves it to the address the node holds. The tool description says this.InvalidArgumentfrom the API, not from the tool.The counts add up (28 + 11 + 14 + 9 = 62) in the README,
development.mdand the test.