test(desktop): a double-click on a panel handle toggles the panel #439

2026-10-18T12:20:01Z

rvnminers-A-and-N commented

2026-10-18 12:20:01 +00:00

Part of #98: "Visible handles when collapsed; drag to reopen without losing pointer control, and double-click to toggle." Agreed with Lior in #117.

app.e2e.mjs already covered dragging a collapsed handle to reopen it, and Enter/Space on a focused handle. Nothing covered the pointer double-click. The handle tells that apart from a press that starts a drag: in finishHistoryResize/finishTopologyResize, two taps within 450 ms and 12 px with no drag between them count as a double-click.

The new test

a double-click on a workspace panel handle closes and reopens the panel, and a single click does not runs these steps on the conversation history handle, and on the topology handle when the window has WebGL:

A single click leaves the panel open. A press is how every drag starts, so it mustn't toggle.
A double-click closes it.
A double-click on the handle where it now sits, after its slide, opens it again.
For history, the reopened state is saved to sisyphus-workspace-layout.

Verification

It passed 4 runs out of 4 locally under xvfb-run, with the CI network lock held, against a freshly built daemon and app.
WebGL was available in software, so the topology half ran too.
Only the test file changes.

Part of #98: "Visible handles when collapsed; drag to reopen without losing pointer control, and **double-click to toggle**." Agreed with Lior in #117. `app.e2e.mjs` already covered dragging a collapsed handle to reopen it, and Enter/Space on a focused handle. Nothing covered the pointer double-click. The handle tells that apart from a press that starts a drag: in `finishHistoryResize`/`finishTopologyResize`, two taps within 450 ms and 12 px with no drag between them count as a double-click. ## The new test `a double-click on a workspace panel handle closes and reopens the panel, and a single click does not` runs these steps on the conversation history handle, and on the topology handle when the window has WebGL: 1. A single click leaves the panel open. A press is how every drag starts, so it mustn't toggle. 2. A double-click closes it. 3. A double-click on the handle where it now sits, after its slide, opens it again. 4. For history, the reopened state is saved to `sisyphus-workspace-layout`. ## Verification - It passed 4 runs out of 4 locally under `xvfb-run`, with the CI network lock held, against a freshly built daemon and app. - WebGL was available in software, so the topology half ran too. - Only the test file changes.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Sisyphus/Sisyphus#439