feat(chat): bind uploaded attachments through structured Ask references #150
No Reviewers
Labels
Clear labels
accessibility
all-platforms
area:agents
area:ai
area:chain
area:ci
area:client
area:daemon
area:p2p
area:project
area:protocol
area:runtime
area:storage
bug
chore
community
dependencies
discussion
discussion/Announcements
discussion/General
discussion/Ideas
discussion/Q&A
discussion/Show and tell
discussion/answered
documentation
duplicate
enhancement
good first issue
help wanted
i18n
infra
invalid
needs:decision
needs:hardware
paired
question
research
security
status:in-review
test
testing
tracking
wontfix
Barrier affecting people with disabilities
Run every platform's packaging and checks on this pull request, not only the three main ones
MCP server, skill, and thinking on the pool
Planner and model providers
Blockchain, SISY, verification
Continuous integration and build workflows
Desktop and web clients
sisyphusd coordinator, worker, scheduler
libp2p hosts, relays, discovery, connections between nodes
Project planning, roadmap, and governance
Protobuf schemas and RPC contracts
Workload execution and environments
Content-addressed storage, IPFS, Kubo, Cluster, S3, names, pinning
Something isn't working
Repository health, templates, Discussions, contributor experience
Updates to actions, Go modules or npm packages
Migrated from GitHub Discussions
GitHub Discussions category: Announcements
GitHub Discussions category: General
GitHub Discussions category: Ideas
GitHub Discussions category: Q&A
GitHub Discussions category: Show and tell
Q&A discussion with an accepted answer
Improvements or additions to documentation
This issue or pull request already exists
New feature or request
Good for newcomers
Extra attention is needed
Translations and right-to-left layouts
Build, CI, releases
This doesn't seem right
Waits on a decision from both owners
Waits on a machine we do not have yet
Built together by both maintainers, with co-authored commits
Further information is requested
Needs investigation or a design decision
Sealing, keys, access control, tokens, the security model
Built and in an open pull request; closes when it merges
Tests, test harnesses and the rehearsal
Roadmap and meta issues
This will not be worked on
type
Feature
A request, idea, or new functionality (GitHub issue type)
type
Task
A specific piece of work (GitHub issue type)
Milestone
No items
No Milestone
V0: prove the loop
Projects
Clear projects
No projects
Sisyphus roadmap
Done
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Sisyphus/Sisyphus#150
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Refs #117, #82. Stacked on #149; updated desktop and daemon must ship together.
Add additive AskRequest.attachment_cids and regenerate with pinned protoc/plugins. Renderer sends uploaded CIDs separately from the model-facing text envelope. Go assistant binds them to the new/existing chat before model/tool execution; all references persist atomically or none do. Later turns retain existing ownership. Legacy Ask without attachments remains compatible; configured assistant implementations without ownership support reject explicit attachments. API caps attachments at 128 per turn.
Extend real-daemon private-chat integration: structured first-turn CID survives the follow-up, encrypted private jobs/results still work, RemoveFile returns FAILED_PRECONDITION while the chat exists, DeleteChat releases ownership, then explicit removal succeeds. Test passed three consecutive runs. Database regression verifies invalid batches leave no partial ownership. grpc-js test verifies attachmentCids reach the server via proto-loader. Full nodedb/API suites, 48 frontend tests, typecheck, production build and diff checks passed; known build warnings remain.
Still NOT automatic cleanup: uploads retain existing permanent user pins; chat deletion releases references but does not automatically unpin/GC, and partial upload/draft cleanup remains pending. Old daemons silently ignore additive protobuf fields; no capability handshake introduced yet, so deploy both sides together. Model-facing text remains for privacy/history compatibility, never for ownership. No live Electron attachment flow or full daemon-suite claim. Build-agents guidance kept node-owned lifecycle in the existing Go stack. No issues closed.