fix(desktop): keep a saved key to its service, do not repeat job events, show attachment previews #116

2026-10-09T08:08:03Z

rvnminers-A-and-N commented

2026-10-09 08:08:03 +00:00

On top of #110. The four items from the review on #16 that were worth fixing before the stack merges.

Model settings tracked only that a key was saved, not for which service, so after changing provider or address the page still said "saved on node" and asked the node to reuse the key. It now remembers the provider and address the key was saved with, and takes has_api_key from the node's answer after saving. (The node itself stopped carrying a key across services in #112.)
Job events were reopened from the start for every live job whenever the set of live jobs changed, and appended, so earlier events appeared twice. Each stream now resumes after the last event shown.
Attachment previews use blob: URLs, which the content policy did not allow for images.
Docs: three lines still described the Rust daemon, removed in #96; AGENTS.md said the node's key is in the database, and it is in node.key.

npm run typecheck, npm test and npm run build pass. Not tried in a running Electron window: this machine has no display.

On top of #110. The four items from the review on #16 that were worth fixing before the stack merges. - **Model settings** tracked only that a key was saved, not for which service, so after changing provider or address the page still said "saved on node" and asked the node to reuse the key. It now remembers the provider and address the key was saved with, and takes `has_api_key` from the node's answer after saving. (The node itself stopped carrying a key across services in #112.) - **Job events** were reopened from the start for every live job whenever the set of live jobs changed, and appended, so earlier events appeared twice. Each stream now resumes after the last event shown. - **Attachment previews** use `blob:` URLs, which the content policy did not allow for images. - **Docs**: three lines still described the Rust daemon, removed in #96; `AGENTS.md` said the node's key is in the database, and it is in `node.key`. `npm run typecheck`, `npm test` and `npm run build` pass. Not tried in a running Electron window: this machine has no display.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Sisyphus/Sisyphus#116